Resolve #944 by scaling control width independently from height#982
Resolve #944 by scaling control width independently from height#982benwbrum wants to merge 1 commit intoUniversalViewer:mainfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Thanks, @benwbrum! This seems to be an improvement overall, but a couple of comments: 1.) If there is a thumbnail image for the audio, that seems to get scaled up as well, which may not be desirable. See manifest https://digital.library.villanova.edu/Item/vudl:283833/Manifest as an example of this. (That's an ugly thumbnail that looks bad no matter what you do, but this seems to make it even worse... not sure if there's a solution). 2.) I notice that you've targeted this branch against main; I wonder if it would be better to target against dev. Hopefully one of the things we can talk about at today's Community Call is branching and releasing conventions, so we can be more consistent in how we do things. I like to compare PR previews against https://www.universalviewer.dev to check for inconsistencies, and I'm seeing a lot of differences here which I believe are related to the dev branch being ahead of the main branch. |
|
@benwbrum, just checking in to see if you saw my review above. Please let me know if you need help moving this work forward! |
2 participants
Description of what you did:
This fixes problems displaying manifests that do not contain ranges in viewers sized below 180px high.
Closes #944