Skip to content

UoE/Test changing of the home page title #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
milanmajchrak wants to merge 1 commit into from
Closed

UoE/Test changing of the home page title #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/themes/datashare/app/home-page/home-news/home-news.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="container">
<div class="d-flex flex-wrap">
<div>
<h2>What is Edinburgh DataShare?</h2>
<h2>Hello dataquest</h2>
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title mentions changing the home page title, but this change only updates an in-page

heading. If the intention is to change the browser/tab title (document <title>), that’s controlled via route metadata (data.title) / HeadTagService and/or the Site DSO name, not this template heading. Please clarify the intended behavior and update the correct source of the page title if needed.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new heading text "Hello dataquest" reads like temporary/test copy and is inconsistent with the following paragraph which still describes Edinburgh DataShare. If this is not intentional, update the heading to match the page content/branding (or remove this test change before merging).

Suggested change
<h2>Hello dataquest</h2>
<h2>Edinburgh DataShare</h2>

Copilot uses AI. Check for mistakes.

<p>
Edinburgh DataShare is a digital repository of research data produced
Expand Down
Loading