Improved download page#41
Improved download page#41msemple1111 wants to merge 7 commits intoUpload:masterfrom msemple1111:master
Conversation
index.html
Outdated
There was a problem hiding this comment.
What's the purpose of this class? Could this be solved using padding or margin instead?
There was a problem hiding this comment.
It should have been solved that way. I have corrected it to use margin instead now.
|
Aside from the code style and code problems, the UI is a bit confusing. Re-using the upload dialog is confusing as previously that sort of UI is a drop zone for files and now it is a download button so it seems weird as a pure button. But aside from that small confusion the UI itself looks bad because the large box is not centered vertically and its hard for the eye to find a space. It would be better with a smaller download button and if you really want a box putting a border around the whole thing. |
Improved the download page like it is suggested here