Skip to content

fix(self-host): preserve native MCP elicitation mode#1459

Open
wan0net wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
wan0net:fix/selfhost-native-elicitation
Open

fix(self-host): preserve native MCP elicitation mode#1459
wan0net wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
wan0net:fix/selfhost-native-elicitation

Conversation

@wan0net

@wan0net wan0net commented Jul 26, 2026

Copy link
Copy Markdown

Summary

  • preserve the parsed elicitation_mode for non-browser in-memory MCP sessions
  • keep the existing browser approval wiring unchanged
  • add a self-host regression test and patch changeset

Why

readElicitationMode accepts native, and the local and Cloudflare hosts pass that value through. The in-memory session store used by self-host instead mapped every non-browser mode to model, so ?elicitation_mode=native exposed the model-resume flow and prevented native MCP elicitation from reaching capable clients.

Validation

  • bun run format:check
  • bun run lint
  • bun run typecheck (43 packages)
  • bun run test (full non-e2e repository suite)
  • bun run --cwd packages/hosts/mcp test (65 tests passed, including the new regression)
  • branch is current with upstream main

@wan0net
wan0net marked this pull request as ready for review July 26, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant