fix: wrong Modal Header when adding users#1594
Open
shivoomiess wants to merge 3 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shivoomiess
requested review from
ellen-wright,
jekabs-karklins and
yoganandaness
and removed request for
a team and
ellen-wright
jekabs-karklins
approved these changes
Jun 22, 2026
yoganandaness
approved these changes
Jul 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect modal header text shown when adding users by making the “add user” modal title configurable in UserManagementTable, then supplying context-appropriate titles from each caller.
Changes:
- Added an
addModalTitleprop toUserManagementTableand wired it to the underlyingProposalPeopleSelectorModaltitle. - Set
addModalTitlefor adding co-proposers, data access users, and visit visitors so the modal header matches the user action.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/frontend/src/components/proposalBooking/CreateUpdateVisit.tsx | Sets an explicit “Add Visitors” modal title when adding visit visitors. |
| apps/frontend/src/components/proposal/DataAccessUsersModal.tsx | Sets an explicit “Add Data Access User” modal title for the data-access user picker. |
| apps/frontend/src/components/proposal/CoProposers.tsx | Sets an explicit “Add co-proposers” modal title for the co-proposer picker. |
| apps/frontend/src/components/common/UserManagementTable.tsx | Introduces addModalTitle and passes it to the people selector modal to control the header text. |
Comment on lines
88
to
91
| title="Data access users" | ||
| addButtonLabel="Add Data Access User" | ||
| addModalTitle="Add Data Access User" | ||
| excludeUserIds={excludeUserIds} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the modal header displayed incorrect text when adding users.
Motivation and Context
The change is required to enhance user experience and to avoid any confusion that might arise due to the wrong modal header. It ensures that the modal header correctly reflects the action being taken by the user.
Changes
addModalTitleinUserManagementTableto customize the title of the add modal.addModalTitleprop inCoProposers,DataAccessUsersModal, andCreateUpdateVisitcomponents to display the correct modal title when adding users.Please note that the above changes will not introduce any breaking changes and will only improve the user interface by resolving the incorrect modal header issue.
How Has This Been Tested?
Fixes Jira Issue
https://jira.ess.eu//browse/SWAP-5365
Depends On
Tests included/Docs Updated?