feat: allow inviting Data Access Users to Proposal with email#1615
Open
shivoomiess wants to merge 18 commits into
Open
feat: allow inviting Data Access Users to Proposal with email#1615shivoomiess wants to merge 18 commits into
shivoomiess wants to merge 18 commits into
Conversation
shivoomiess
changed the title
yoganandaness
left a comment
yoganandaness
left a comment
Contributor
There was a problem hiding this comment.
@shivoomiess Kindly attach relevant video or screenshot
| user_id: userId, | ||
| }; | ||
|
|
||
| await trx('data_access_user_has_proposal') |
yoganandaness
requested changes
Jul 1, 2026
yoganandaness
left a comment
yoganandaness
left a comment
Contributor
There was a problem hiding this comment.
- kindly test all pieces of change
- Attach video or pic if possible
- Pls have clean diff
jekabs-karklins
left a comment
jekabs-karklins
left a comment
Contributor
There was a problem hiding this comment.
Over all looks very good :raisedhands:
As this is a bigger PR I think you will get a bit more comments :).
I have checked the PR and left some comments, and Happy to chat if any help or clarification needed.
| ); | ||
| // already a data access user | ||
| if (isDataAccessUser) { | ||
| return; |
Contributor
There was a problem hiding this comment.
suggestion: although not a real world use case for now, can we have a continue here? If at some point there are two data access claims attached to the invite and for the first claim isDataAccessUser is already true, the second will not be avaluated
shivoomiess
commented
Jul 3, 2026
shivoomiess
left a comment
shivoomiess
left a comment
Collaborator
Author
There was a problem hiding this comment.
incorporated feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the capability to invite data access users to a proposal by creating a new data access claim.
Motivation and Context
This change is required to allow data access users to be linked directly to proposals, enabling them to view and manipulate data related to the proposal they are invited to. This enhances collaboration and data management in the project.
Changes
How Has This Been Tested?
Fixes Jira Issue
https://jira.ess.eu//browse/SWAP-5408
Depends On
Tests included/Docs Updated?