feat: diamond email handler changes#1617
Open
GrantDLS wants to merge 4 commits into
Open
Conversation
GrantDLS
changed the title
GrantDLS
requested review from
William-Edwards-STFC
and removed request for
a team
Collaborator
|
Should be fix:. not feat: https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines |
Collaborator
|
lgtm: |
William-Edwards-STFC
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds changes to the DLS email handler. Handling of possible null values in a user's
preferrednameare handled, and instruments selected in a proposal are dynamically found in the proposal submission.How Has This Been Tested
No core changes have been made to the application, so only manual testing has been carried out.
Tests included/Docs Updated?