fix: email and proposal download status action logs pages#1622
Open
mutambaraf wants to merge 7 commits into
Open
fix: email and proposal download status action logs pages#1622mutambaraf wants to merge 7 commits into
mutambaraf wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: UserOfficeProject/issue-tracker#1623
The Email and Proposal Download status action logs pages were throwing a GraphQL INTERNAL_SERVER_ERROR ("Status action not found ActionId: X connectionId: Y") for most historical rows, because a data migration bug (the workflow-overhaul release) left many status_actions_logs rows pointing at connection_id/action_id combinations that no longer exist in workflow_status_connection_has_actions. This PR makes that a handled, expected state instead of a hard error, and prevents users from trying to replay a log that has no configuration left to replay against.
Motivation and Context
How Has This Been Tested
Added tests
Fixes
Changes
Depends on
Tests included/Docs Updated?