Skip to content

Packaging hardening: add LICENSE, remove dead vest.yaml pathing, and fix matplotlib style compatibility#53

Draft
jaesun57 with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-missing-license-and-vendor
Draft

Packaging hardening: add LICENSE, remove dead vest.yaml pathing, and fix matplotlib style compatibility#53
jaesun57 with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-missing-license-and-vendor

Conversation

Copilot AI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This PR addresses packaging/runtime breakages called out in the audit: missing LICENSE metadata target, invalid uv source override to non-existent vendor/omas, non-portable runtime fallback to dead vest.yaml, and a matplotlib style name that breaks on supported versions.

  • Packaging metadata alignment

    • Added top-level LICENSE (Apache-2.0 text) to satisfy pyproject.toml license.file and README link expectations.
    • Updated setuptools package data to include vaft/.hscfg in built artifacts.
  • Dependency source cleanup

    • Removed [tool.uv.sources].omas editable path override to vendor/omas (directory is not in-repo), leaving standard dependency resolution intact.
  • Dead config removal and runtime behavior tightening

    • Deleted vaft/machine_mapping/vest.yaml (unused/dead, malformed).
    • Updated vaft/machine_mapping/utils.py path resolution to stop implicitly defaulting to vest.yaml; callers must provide a valid info_file, and missing files now raise explicit errors.
  • Matplotlib compatibility fix

    • Replaced deprecated/removed style alias in EFIT summary workflow:
      # before
      plt.style.use('seaborn')
      
      # after
      plt.style.use('seaborn-v0_8')
  • Targeted regression coverage

    • Added focused checks for:
      • LICENSE presence,
      • absence of vendor/omas override,
      • explicit info_file requirement (no hidden vest.yaml fallback),
      • updated matplotlib style string in EFIT analysis script.

Copilot AI changed the title [WIP] Fix missing LICENSE file and vendor directory Packaging hardening: add LICENSE, remove dead vest.yaml pathing, and fix matplotlib style compatibility Jul 22, 2026
Copilot AI requested a review from jaesun57 July 22, 2026 07:27
@jaesun57

Copy link
Copy Markdown
Collaborator

@claude review pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P4] Packaging: LICENSE missing, vendor/omas missing, vest.yaml is dead config

2 participants