Skip to content

vey-daemon: reuse broadcast channel to update runtime config in place#63

Open
zh-jq wants to merge 4 commits into
mainfrom
listen-runtime
Open

vey-daemon: reuse broadcast channel to update runtime config in place#63
zh-jq wants to merge 4 commits into
mainfrom
listen-runtime

Conversation

@zh-jq

@zh-jq zh-jq commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e91f90da99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/vey-daemon/src/listen/quic.rs Outdated
Comment thread lib/vey-daemon/src/listen/quic.rs
Comment thread vey-proxy/src/config/server/plain_quic_port.rs
Comment thread vey-gateway/src/config/server/plain_quic_port.rs
}

async fn goto_offline(&self, listener: Endpoint) {
listener.wait_idle().await;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the offline rebind before draining

On QuitRuntime for a plain_quic_port with offline_rebind_port configured, goto_offline now just waits on the endpoint while it remains bound to the public UDP port; on platforms using SO_REUSEPORT, the replacement listener and this idle endpoint can share traffic, so some new connection Initial packets can be delivered to the offline endpoint and hang. The previous rebind-to-offline-port path avoided that before wait_idle.

Useful? React with 👍 / 👎.

@zh-jq
zh-jq force-pushed the listen-runtime branch 5 times, most recently from e5973fa to e2ec56f Compare July 16, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant