vey-daemon: reuse broadcast channel to update runtime config in place#63
vey-daemon: reuse broadcast channel to update runtime config in place#63zh-jq wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e91f90da99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| async fn goto_offline(&self, listener: Endpoint) { | ||
| listener.wait_idle().await; |
There was a problem hiding this comment.
Preserve the offline rebind before draining
On QuitRuntime for a plain_quic_port with offline_rebind_port configured, goto_offline now just waits on the endpoint while it remains bound to the public UDP port; on platforms using SO_REUSEPORT, the replacement listener and this idle endpoint can share traffic, so some new connection Initial packets can be delivered to the offline endpoint and hang. The previous rebind-to-offline-port path avoided that before wait_idle.
Useful? React with 👍 / 👎.
e5973fa to
e2ec56f
Compare
No description provided.