[k2] add Date/Time classes to light runtime #1481

Shamzik · 2025-12-08T16:26:17Z

This first part of implementing Date/Time classes. Here implemented:

DateInterval;
DateTimeZone;
DateTimeImmutable;
DateTime.

builtin-functions/kphp-light/stdlib/time-functions.txt

runtime-common/core/core-types/decl/string_decl.inl

runtime-light/stdlib/time/time-functions.cpp

apolyakov

I've reviewed and noted some comments. Please, take into account that these comments should be applied to whole PR, not only the places where I left those comments

runtime-common/stdlib/string/string-context.h

runtime-light/stdlib/time/timelib-functions.h

runtime-light/stdlib/time/timelib-constants.h

runtime-light/stdlib/time/timelib-functions.h

runtime-common/core/core-types/decl/string_decl.inl

runtime-light/stdlib/time/timelib-functions.h

runtime-light/stdlib/time/time-state.h

runtime-light/stdlib/time/datetimezone.h

runtime-light/stdlib/time/date-time-zone.h

runtime-light/stdlib/time/date-time-zone.cpp

runtime-light/stdlib/time/dateinterval.cpp

runtime-light/stdlib/time/timelib-functions.cpp

runtime-light/stdlib/time/timelib-functions.h

runtime-light/stdlib/time/timelib-functions.cpp

apolyakov · 2026-01-21T16:32:14Z

runtime-light/stdlib/time/timelib-functions.cpp

+std::expected<rel_time, error_container> parse_interval(std::string_view formatted_interval) noexcept {
+  timelib_time* b{nullptr};
+  timelib_time* e{nullptr};
+  kphp::memory::libc_alloc_guard _{};


Let's not create it until it's actually used

apolyakov · 2026-01-21T16:33:07Z

runtime-light/stdlib/time/timelib-functions.cpp

+  kphp::memory::libc_alloc_guard _{};
+  vk::final_action e_deleter{[e]() { free(e); }};
+  vk::final_action b_deleter{[b]() { free(b); }};
+  timelib_rel_time* p{nullptr};


I'd like to see usage of your timelib types, e.g. kphp::timelib::rel_time here. It can be a test for their usability

This isn't the best place to test type wrappers. Wrapped types should be used with wrapped functions, not within wrapped functions. Here, we're using raw timelib functions, which require raw timelib types.

Of course, we could define our own pointer holder, which would provide access to the pointer by reference. But that seems as overkill to me. See the "kshamazov/datetime-structs" branch for an implementation example.

apolyakov · 2026-01-21T16:33:28Z

runtime-light/stdlib/time/timelib-functions.cpp

+  return std::unexpected{error_container{errors, kphp::timelib::details::error_container_destructor}};
+}
+
+time add_time_interval(const kphp::timelib::time& t, const kphp::timelib::rel_time& interval) noexcept {


No need to define everything in cpp file

apolyakov · 2026-01-21T16:35:55Z

runtime-light/stdlib/time/timelib-functions.cpp

+
+} // namespace
+
+time_offset construct_time_offset(const kphp::timelib::time& t) noexcept {


I'd like to see fully qualified type here. I don't want to make C++ compiler's job, i.e. name lookup

apolyakov · 2026-01-21T16:52:24Z

runtime-light/stdlib/time/timelib-functions.cpp

+  now->tz_info = time->tz_info;
+  now->zone_type = TIMELIB_ZONETYPE_ID;
+
+  namespace chrono = std::chrono;


In this case it's not a problem, but let's not introduce bad pattern into runtime: do not mix objects that are designed to be allocated/deallocated in the context of libc_alloc_guard with objects that are not designed for that, e.g. every other object

I'm not sure I understand you. But I moved chrono objects up

apolyakov · 2026-01-21T16:52:47Z

runtime-light/stdlib/time/timelib-functions.cpp

+  return std::make_pair(std::move(res), std::move(errors));
+}
+
+void set_date(kphp::timelib::time& t, int64_t y, int64_t m, int64_t d) noexcept {


I don't see any reason to define such function in the header

apolyakov · 2026-01-21T18:17:59Z

runtime-light/stdlib/time/timelib-functions.cpp

-  instance_timelib_zone_cache.put(tzinfo);
-  return tzinfo;
+  int errc{}; // it's intentionally declared as 'int' since timelib_parse_tzfile accepts 'int'
+  kphp::timelib::tzinfo tzinfo{timelib_parse_tzfile(name.data(), tzdb, std::addressof(errc)), kphp::timelib::details::tzinfo_destructor};


It seems you've missed libc_alloc_guard here

apolyakov · 2026-01-21T18:20:51Z

runtime-light/stdlib/time/timelib-timezone-cache.h

+      if (tzinfo == nullptr || tzinfo->name == nullptr) [[unlikely]] {
+        return;
+      }
+      put(std::move(tzinfo));


Let's refactor this a bit to make sure put is not called while libc_alloc_guard is active

apolyakov · 2026-01-30T15:19:36Z

runtime-light/stdlib/time/timelib-functions.h

+
 namespace kphp::timelib {

+using static_buf = std::array<char, 128>;


It's actually unused

apolyakov · 2026-01-30T15:24:12Z

runtime-light/stdlib/time/timelib-functions.h

+
+inline std::expected<std::pair<kphp::timelib::time_holder, kphp::timelib::error_container_holder>, kphp::timelib::error_container_holder>
+parse_time(std::string_view formatted_time) noexcept {
+  timelib_error_container* errors{};


I think it's better to make kphp::timelib::error_container_holder{nullptr, ...} constructed as soon as possible, e.g. before any branches to make memory leak here impossible. Same for other functions

apolyakov · 2026-01-30T15:35:28Z

runtime-light/stdlib/time/timelib-functions.h

+  t->y = y;
+  t->m = 1;
+  t->d = 1;
+  std::memset(std::addressof(t->relative), 0, sizeof(t->relative));


Missing include for <cstring>

apolyakov · 2026-01-30T15:37:10Z

runtime-light/stdlib/time/timelib-functions.cpp

+  return std::unexpected{kphp::timelib::error_container_holder{errors, kphp::timelib::details::error_container_destructor}};
+}
+
+kphp::timelib::rel_time_holder get_time_interval(const kphp::timelib::time_holder& time1, const kphp::timelib::time_holder& time2, bool absolute) noexcept {


Let's move this definition to header file as its small enough to be inlined

apolyakov · 2026-01-30T15:38:35Z

runtime-light/stdlib/time/timelib-functions.cpp

-  if (datetime.empty()) [[unlikely]] {
+std::expected<std::pair<kphp::timelib::time_holder, kphp::timelib::error_container_holder>, kphp::timelib::error_container_holder>
+parse_time(std::string_view formatted_time, const kphp::timelib::time_holder& t) noexcept {
+  auto expected{parse_time(formatted_time)};


Let's use fully qualified names. Otherwise, it's so simple to understand where the function goes from

apolyakov · 2026-01-30T15:51:28Z

runtime-light/stdlib/time/date-time-zone.h

+inline class_instance<C$DateTimeZone> f$DateTimeZone$$__construct(const class_instance<C$DateTimeZone>& self, const string& timezone) noexcept {
+  auto expected_tzi{kphp::timelib::get_timezone_info({timezone.c_str(), timezone.size()})};
+  if (!expected_tzi.has_value()) [[unlikely]] {
+    static constexpr std::string_view before_timezone{"DateTimeZone::__construct(): Unknown or bad timezone ("};


Let's use capital letters for static variables. Please, also check other files

apolyakov · 2026-01-30T15:54:11Z

runtime-light/stdlib/time/date-time-zone.h

+}
+
+inline string f$DateTimeZone$$getName(const class_instance<C$DateTimeZone>& self) noexcept {
+  return string{self->tzi->get()->name};


We can't create new string on every getName invocation

We can't skip safety checks. In case you're 'almost sure' bad thing won't happen, add kphp::log::assertion

apolyakov · 2026-01-30T15:59:56Z

runtime-light/stdlib/time/time-functions.h

-  result.set_value(string{"weekday", 7}, string{weekday.data(), static_cast<string::size_type>(weekday.size())});
-  result.set_value(string{"month", 5}, string{month.data(), static_cast<string::size_type>(month.size())});
+  result.set_value(string{"weekday", 7}, string{weekday});
+  result.set_value(string{"month", 5}, string{month});


nit: actually we can use std::strlen here as in modern compilers it's implemented as constexpr

apolyakov · 2026-01-30T16:03:37Z

runtime-light/stdlib/time/date-time-immutable.cpp

+  return date_time;
+}
+
+class_instance<C$DateTimeImmutable> f$DateTimeImmutable$$createFromMutable(const class_instance<C$DateTime>& object) noexcept {


Let's move this to the header file

apolyakov · 2026-01-30T16:05:21Z

runtime-light/stdlib/time/date-interval.h

+  }
+};
+
+inline class_instance<C$DateInterval> f$DateInterval$$__construct(const class_instance<C$DateInterval>& self, const string& duration) noexcept {


This can be moved to cpp file

Shamzik marked this pull request as ready for review December 10, 2025 10:26

Shamzik force-pushed the kshamazov/datetime branch from d1df9ec to 244c045 Compare December 10, 2025 22:05

Shamzik self-assigned this Dec 10, 2025

Shamzik added the k2 k2 related label Dec 10, 2025

Shamzik added this to the next milestone Dec 10, 2025

Shamzik changed the title ~~[k2] add Date/Time classes (except DateTime) to light runtime~~ [k2] add Date/Time classes to light runtime Dec 10, 2025

Shamzik requested review from PetrShumilov, apolyakov and astrophysik December 11, 2025 16:17

apolyakov reviewed Dec 11, 2025

View reviewed changes

builtin-functions/kphp-light/stdlib/time-functions.txt Outdated Show resolved Hide resolved

runtime-common/core/core-types/decl/string_decl.inl Outdated Show resolved Hide resolved

runtime-light/stdlib/time/time-functions.cpp Outdated Show resolved Hide resolved

Shamzik requested a review from apolyakov December 12, 2025 11:44

DrDet modified the milestones: 14.12.2025, next Dec 12, 2025

Shamzik force-pushed the kshamazov/datetime branch from 49fc0f4 to a96050c Compare December 16, 2025 09:20

apolyakov requested changes Dec 26, 2025

View reviewed changes

Shamzik requested a review from apolyakov January 16, 2026 16:14

apolyakov requested changes Jan 17, 2026

View reviewed changes

apolyakov reviewed Jan 17, 2026

View reviewed changes

Shamzik force-pushed the kshamazov/datetime branch from 58b34bb to eb0dc06 Compare January 19, 2026 15:57

Shamzik requested a review from apolyakov January 21, 2026 12:10

PetrShumilov requested changes Jan 21, 2026

View reviewed changes

Shamzik requested a review from PetrShumilov January 21, 2026 14:42

apolyakov reviewed Jan 21, 2026

View reviewed changes

runtime-light/stdlib/time/timelib-functions.cpp Outdated Show resolved Hide resolved

apolyakov reviewed Jan 21, 2026

View reviewed changes

Shamzik added 15 commits January 30, 2026 18:03

fixes

7e49066

fix timelib.cmake

2b89c3b

fixes

26deb64

common define for runtimes

8d7ef0f

2026

4a4317b

fix gen_error_msg

e37820f

undo template files

2bec904

remove type aliases

c4929b0

move sign functions up

958bc6e

improve string::append

cd17d65

cc

1bf3373

fix checkdate

b472cdb

fix includes

d370b56

link runtime-light to timelib

c658646

write diff as bytes

92b7f45

Shamzik force-pushed the kshamazov/datetime branch from 89d240b to 92b7f45 Compare January 30, 2026 15:07

Shamzik added 4 commits January 30, 2026 18:27

revert compiler-settings.cpp format

7147fd8

remove static_buf alias

63b990e

use holders as possible

47fcb5d

make default methods of timezone_cache

22fcc11

Shamzik requested a review from PetrShumilov January 30, 2026 16:06

apolyakov reviewed Jan 30, 2026

View reviewed changes

Shamzik added 8 commits January 30, 2026 19:18

move string constants of get_last_errors into image state

6f896f4

#include <cstring>

867cdd6

move get_time_interval to header

1d2db98

parse_time -> kphp::timelib::parse_time

fa2c595

add warning in timezone_cache init

62ecfa8

fix ExtraRefCnt::for_global_const

b719fd4

auto -> const auto*

183e0ec

uppercase static constexpr

7b42135


		} // namespace

		time_offset construct_time_offset(const kphp::timelib::time& t) noexcept {


		namespace kphp::timelib {

		using static_buf = std::array<char, 128>;

[k2] add Date/Time classes to light runtime #1481

Are you sure you want to change the base?

[k2] add Date/Time classes to light runtime #1481

Uh oh!

Conversation

Shamzik commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

apolyakov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Shamzik commented Dec 8, 2025 •

edited

Loading