Open
Conversation
Added custom editor tools, this is supposed to be in the static files for the current project (whatever it is), it can contain any custom tool (I got this one from the editorjs wiki)
With this patch you can use something like
editorjs_config={
"tools": {
"Custom": {
"Customimage": {
"class": "SimpleImage"
}
}
}
}
And it will be evaluated (of course, the class name should be added by someone who is trusted, and should never depend on user input as it would lead to xss)
Explained how to use custom tools
Author
|
Here's an example of custom-editorjs-tools.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I managed to handle custom block tools, I updated the readme with an explanation of how I did it, it's not a really clean code, you have to serve a file named "custom-editorjs-tools.js" containing the custom tools and to get the class from the classname I use an eval, but if the classname doesn't depend on user input (and that will probably be the case), it should be safe to use.
I hope you'll merge this, or at least take inspiration from this PR as I think it could be helpfull to most people that are using this.
Thanks.