feat: replace Mint slideshow with CaramOS custom slides#52
Open
2vhoc wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a custom Ubiquity installer slideshow for CaramOS (Vietnamese language), including new slides, styling, and slideshow sizing configuration.
Changes:
- Added
slideshow.confto set slideshow dimensions. - Added multiple Vietnamese HTML slides plus a new slideshow
index.htmlcontroller. - Added a shared CSS theme and assets (e.g., Lotus SVG icon).
Reviewed changes
Copilot reviewed 10 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| config/includes.chroot/usr/share/ubiquity-slideshow/slideshow.conf | Defines slideshow width/height for the installer slideshow. |
| config/includes.chroot/usr/share/ubiquity-slideshow/slides/index.html | Adds the slideshow frame + JS logic to rotate between slides. |
| config/includes.chroot/usr/share/ubiquity-slideshow/slides/*.html | Adds new Vietnamese-language slides (welcome, apps, Vietnamese input, Windows app compatibility, updates, community). |
| config/includes.chroot/usr/share/ubiquity-slideshow/slides/link/slideshow.css | Adds shared styling/animations/layout for the slideshow. |
| config/includes.chroot/usr/share/ubiquity-slideshow/slides/icons-app/fcitx-lotus-README.svg | Adds an icon asset used by the Vietnamese input slide. |
| config/includes.chroot/usr/share/ubiquity-slideshow/slides/.vscode/settings.json | Adds editor settings under the shipped slideshow directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+6
| { | ||
| "workbench.colorCustomizations": { | ||
| "minimap.background": "#00000000", | ||
| "scrollbar.shadow": "#00000000" | ||
| } | ||
| } No newline at end of file |
Comment on lines
+26
to
+35
| <a href="https://caramos.vietnamlinuxfamily.net/" target="_blank" class="community-link primary"> | ||
| <span>🌐</span> Website CaramOS | ||
| </a> | ||
| <a href="https://www.facebook.com/groups/vietnamlinuxcommunity" target="_blank" | ||
| class="community-link"> | ||
| <img src="icons-app/Facebook_Logo_(2019).png" alt="Facebook"> Cộng đồng Facebook | ||
| </a> | ||
| <a href="https://github.com/VN-Linux-Family/CaramOS" target="_blank" class="community-link"> | ||
| <img src="icons-app/github.png" style="filter: invert(1);" alt="GitHub"> Mã nguồn GitHub | ||
| </a> |
Comment on lines
+427
to
+457
| .slide-footer { | ||
| position: absolute; | ||
| /* bottom: -50%; | ||
| */ | ||
| top: 10%; | ||
| left: 50%; | ||
| transform: translateX(-50%); | ||
| font-size: 19px; | ||
| color: #64748b; | ||
| letter-spacing: 1.5px; | ||
| font-weight: 600; | ||
| text-transform: uppercase; | ||
| text-align: center; | ||
| opacity: 0.8; | ||
| } | ||
|
|
||
| .slide-footer { | ||
| position: absolute; | ||
| /* bottom: 50%; */ | ||
|
|
||
| top: 95%; | ||
| left: 50%; | ||
| transform: translateX(-50%); | ||
| font-size: 14px; | ||
| color: #64748b; | ||
| letter-spacing: 1.4px; | ||
| font-weight: 800; | ||
| text-transform: uppercase; | ||
| text-align: center; | ||
| opacity: 0.8; | ||
| } No newline at end of file |
Comment on lines
+85
to
+103
| // Re-bind focus loop mechanism to ensure keys work inside the iframe if clicked | ||
| setInterval(function () { | ||
| try { | ||
| var frameDoc = frame.contentWindow.document; | ||
| if (!frameDoc.hasKeydownListener) { | ||
| frameDoc.addEventListener('keydown', function (e) { | ||
| if (e.key === 'ArrowRight') { nextSlide(); resetTimer(); } | ||
| else if (e.key === 'ArrowLeft') { prevSlide(); resetTimer(); } | ||
| }); | ||
| frameDoc.addEventListener('click', function (e) { | ||
| // Không chuyển slide nếu nhấn vào link hoặc button bên trong iframe | ||
| if (e.target.closest('a') || e.target.closest('button')) return; | ||
| nextSlide(); | ||
| resetTimer(); | ||
| }); | ||
| frameDoc.hasKeydownListener = true; | ||
| } | ||
| } catch (e) { } | ||
| }, 1000); |
Comment on lines
+33
to
+35
| <div class="showcase-icon" style="background: #ebf8ff; border-color: #3182ce;"><img | ||
| src="screenshots/caramos-logo.png" style="filter: grayscale(0.5); opacity: 0.8;" alt="OS"> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.