Skip to content

Comments

Removes the use of the custom OpenClass annotation and the associated kotlin-allopen plugin#595

Open
314systems wants to merge 2 commits intoVREMSoftwareDevelopment:mainfrom
314systems:allopen
Open

Removes the use of the custom OpenClass annotation and the associated kotlin-allopen plugin#595
314systems wants to merge 2 commits intoVREMSoftwareDevelopment:mainfrom
314systems:allopen

Conversation

@314systems
Copy link
Contributor

Summary

  • Removes the use of the custom OpenClass annotation and the associated kotlin-allopen plugin

Checklist (required before marking ready)

  • I added or updated unit tests (see app/src/test/)
  • I followed the project's coding style (ktlint) and formatting
  • I ran lint and addressed or documented any warnings
  • CI checks pass (unit tests, coverage, lint)
  • No sensitive data, keys, or secrets are included

Copilot AI review requested due to automatic review settings February 22, 2026 09:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the custom @OpenClass annotation and the associated kotlin-allopen plugin, replacing them with Mockito's inline MockMaker for testing. This simplifies the build configuration by eliminating the need to explicitly make Kotlin classes open for mocking purposes.

Changes:

  • Removed the kotlin-allopen plugin and associated configuration from build files
  • Deleted the custom OpenClass annotation definition
  • Removed all usages of the @OpenClass annotation from production classes
  • Added Mockito's mock-maker-inline configuration to enable mocking of final Kotlin classes
  • Added open modifier to two specific methods (selections property and color method) that are overridden by subclasses

Reviewed changes

Copilot reviewed 41 out of 44 changed files in this pull request and generated no comments.

Show a summary per file
File Description
build.gradle Removed kotlin-allopen plugin classpath dependency
app/build.gradle Removed kotlin-allopen plugin and allOpen configuration block
app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker Added mock-maker-inline configuration to enable mocking of final classes
app/src/main/kotlin/com/vrem/annotation/OpenClass.kt Deleted the custom OpenClass annotation file
app/src/main/kotlin/com/vrem/wifianalyzer/wifi/filter/adapter/BasicFilterAdapter.kt Made selections property open for overriding in SSIDAdapter
app/src/main/kotlin/com/vrem/wifianalyzer/wifi/filter/adapter/EnumFilterAdapter.kt Made color method open for overriding in StrengthAdapter
Multiple production class files (46 files) Removed @OpenClass annotations and associated imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant