Use numbered arguments for better localization support#596
Open
314systems wants to merge 1 commit intoVREMSoftwareDevelopment:mainfrom
Open
Use numbered arguments for better localization support#596314systems wants to merge 1 commit intoVREMSoftwareDevelopment:mainfrom
314systems wants to merge 1 commit intoVREMSoftwareDevelopment:mainfrom
Conversation
…ter localization support
There was a problem hiding this comment.
Pull request overview
This PR updates string resource format specifiers from positional (%s) to numbered (%1$s, %2$s) for better localization support and to eliminate build warnings. The change affects the channel_rating_best_alternative string resource across all 18 locale files in the application.
Changes:
- Updated format specifiers in
channel_rating_best_alternativestring from%sto%1$sand%2$sacross all locale files - Enables translators to reorder arguments based on grammatical requirements of different languages
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Updated default English string with numbered format specifiers |
| app/src/main/res/values-zh-rTW/strings.xml | Updated Traditional Chinese translation with numbered format specifiers |
| app/src/main/res/values-zh-rCN/strings.xml | Updated Simplified Chinese translation with numbered format specifiers |
| app/src/main/res/values-uk/strings.xml | Updated Ukrainian translation with numbered format specifiers |
| app/src/main/res/values-tr/strings.xml | Updated Turkish translation with numbered format specifiers |
| app/src/main/res/values-ru/strings.xml | Updated Russian translation with numbered format specifiers |
| app/src/main/res/values-pt/strings.xml | Updated Portuguese translation with numbered format specifiers |
| app/src/main/res/values-pt-rBR/strings.xml | Updated Brazilian Portuguese translation with numbered format specifiers |
| app/src/main/res/values-pl/strings.xml | Updated Polish translation with numbered format specifiers |
| app/src/main/res/values-nl/strings.xml | Updated Dutch translation with numbered format specifiers |
| app/src/main/res/values-ja/strings.xml | Updated Japanese translation with numbered format specifiers |
| app/src/main/res/values-it/strings.xml | Updated Italian translation with numbered format specifiers |
| app/src/main/res/values-hu/strings.xml | Updated Hungarian translation with numbered format specifiers |
| app/src/main/res/values-fr/strings.xml | Updated French translation with numbered format specifiers |
| app/src/main/res/values-es/strings.xml | Updated Spanish translation with numbered format specifiers |
| app/src/main/res/values-el/strings.xml | Updated Greek translation with numbered format specifiers |
| app/src/main/res/values-de/strings.xml | Updated German translation with numbered format specifiers |
| app/src/main/res/values-bg/strings.xml | Updated Bulgarian translation with numbered format specifiers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
=========================================
Coverage 97.83% 97.83%
Complexity 975 975
=========================================
Files 121 121
Lines 2581 2581
Branches 211 211
=========================================
Hits 2525 2525
Misses 19 19
Partials 37 37 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary