-
Notifications
You must be signed in to change notification settings - Fork 18
Enabling Plan mode on pyvroom #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
aa2f910
adds DUSE_LIBGLPK flag
juanluisrto bae5493
adding missing dependencies
jonathf 76628bd
add glpk
juanluisrto 730f541
adds linking flag
juanluisrto be16fb2
adding glpk to cibuildwheel
jonathf 6829a8e
adding more glpk to cibuildwheel
jonathf 62d0dad
giving up on win, updating on linux
jonathf a67b809
resetting conan
jonathf 59fb238
try without the recipe version
nilsnolde b71d2af
trigger win
nilsnolde 16f4a82
conan: only build missing binary packages
nilsnolde 3e022e0
revert workflow stuff
nilsnolde 4f9128c
don't build CI on irrelevant files
nilsnolde 645cdcd
update readme
nilsnolde 23570da
Fix Conan GLPK linking on macOS
blegat 4ee9dde
Add plan mode test
blegat 7403465
Fix tests
blegat 72fa346
bugfixes
jonathf f9bd6cd
Attempt to fix ci
blegat b6a16fc
Try fix
blegat ab88bed
Try fix
blegat d911933
Fix coverage
blegat 25ee57f
Fix doctest
blegat 8e78878
Attempt to fix tests
blegat 6e23849
Move pandas back
blegat 166d11e
Use openssl back in --build
blegat 1019b8a
Apply suggestion from @blegat
blegat 5486dcb
Merge branch 'main' into bugfix/plan-mode
blegat f93cf97
Build glpk if needed
blegat 985440b
Use --build=missing
blegat 64813c6
Add comments
blegat 530319f
Make GLPK mandatory
blegat 147b5d8
Apply suggestion from @jonathf
blegat 37c8fc1
Apply suggestion from @blegat
blegat ec8f40d
Apply suggestion from @blegat
blegat bf55850
Move import pytest to the top
blegat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| [requires] | ||
| openssl/1.1.1m | ||
| asio/1.21.0 | ||
| glpk/5.0 | ||
|
|
||
| [generators] | ||
| json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two possible solutions:
Cost stays 6411; the solver is just returning a different (equivalent) route order.
This makes the doctest fail on ci if I write one solution here and the solver returns another one.
The change here make it work in both cases
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the README exists primarily for domonstration purpouses. If the example is ambiguous, I think the right correction is to change the example so the ambiguity doesn't arrises, not to do check for multiple solutions.