Skip to content

Fixes "non-None" timeout in solve func#141

Merged
jonathf merged 1 commit into
VROOM-Project:mainfrom
merschformann:main
Apr 21, 2026
Merged

Fixes "non-None" timeout in solve func#141
jonathf merged 1 commit into
VROOM-Project:mainfrom
merschformann:main

Conversation

@merschformann

Copy link
Copy Markdown
Contributor

Description

Fixes a small bug when passing an actual timedelta to the solve func. The change simply removes the redundant check for None as a type, which Python does not consider a proper type (apparently that would be type(None) instead, but is not necessary anyway).

Changes

  • Fixes timeout parameter of solve func for "non-None" values.

Notes

Thanks for all the work on the project. ❤️

I hope this makes sense and is in an adequate form. I tried to keep it minimal.

@codecov

codecov Bot commented Apr 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.6%. Comparing base (72199b3) to head (7897225).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #141   +/-   ##
=====================================
  Coverage   79.6%   79.6%           
=====================================
  Files         29      29           
  Lines       1913    1913           
  Branches     150     149    -1     
=====================================
  Hits        1523    1523           
  Misses       378     378           
  Partials      12      12           
Flag Coverage Δ
binding 71.7% <ø> (ø)
python 92.1% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonathf

jonathf commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Looks good!

@jonathf
jonathf merged commit bb4ea9c into VROOM-Project:main Apr 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants