Fixes "non-None" timeout in solve func#141
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=====================================
Coverage 79.6% 79.6%
=====================================
Files 29 29
Lines 1913 1913
Branches 150 149 -1
=====================================
Hits 1523 1523
Misses 378 378
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Collaborator
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a small bug when passing an actual
timedeltato thesolvefunc. The change simply removes the redundant check forNoneas a type, which Python does not consider a proper type (apparently that would betype(None)instead, but is not necessary anyway).Changes
timeoutparameter ofsolvefunc for "non-None" values.Notes
Thanks for all the work on the project. ❤️
I hope this makes sense and is in an adequate form. I tried to keep it minimal.