Skip to content

Convert Int64s into strings before going into JavaScript for IDs. #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Solarmax2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Convert Int64s into strings before going into JavaScript for IDs. #1360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Valour/Client/ContextMenu/Menus/ChannelContextMenu.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
}

private async Task OnClickCopyId(){
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.Channel.Id);
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.Channel.Id.ToString());
ToastContainer.Instance.AddToast(new ToastData("Copied!", "Channel ID copied to clipboard", ToastProgressState.Success));
}

Expand Down
4 changes: 2 additions & 2 deletions Valour/Client/ContextMenu/Menus/Member/MemberContextMenu.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@ else
}

private async Task OnClickCopyMemberId(){
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.Member.Id);
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.Member.Id.ToString());
ToastContainer.Instance.AddToast(new ToastData("Copied!", "Member ID copied to clipboard", ToastProgressState.Success));
}

private async Task OnClickCopyUserId(){
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.Member.UserId);
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.Member.UserId.ToString());
ToastContainer.Instance.AddToast(new ToastData("Copied!", "User ID copied to clipboard", ToastProgressState.Success));
}

Expand Down
2 changes: 1 addition & 1 deletion Valour/Client/ContextMenu/Menus/MessageContextMenu.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
}

private async Task OnClickCopyId(){
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.Message.Id);
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.Message.Id.ToString());
ToastContainer.Instance.AddToast(new ToastData("Copied!", "Message ID copied to clipboard", ToastProgressState.Success));
}
}
2 changes: 1 addition & 1 deletion Valour/Client/ContextMenu/Menus/PlanetContextMenu.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@

private async Task OnClickCopyId()
{
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.Planet.Id);
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.Planet.Id.ToString());
ToastContainer.Instance.AddToast(new ToastData("Copied!", "Planet ID copied to clipboard", ToastProgressState.Success));
}

Expand Down
4 changes: 3 additions & 1 deletion Valour/Client/ContextMenu/Menus/UserContextMenu.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,10 @@ else
ToastContainer.Instance.AddToast(new ToastData("Copied!", "Username copied to clipboard", ToastProgressState.Success));
}

// I think this and the one for Member should be consolidated to a single
// function, they appear to do the exact same thing, and it's duplicate work.
private async Task OnClickCopyUserId(){
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.User.Id);
await JsRuntime.InvokeVoidAsync("clipboardCopy.copyText", Data.User.Id.ToString());
ToastContainer.Instance.AddToast(new ToastData("Copied!", "User ID copied to clipboard", ToastProgressState.Success));
}

Expand Down