Fix the ability to send messages with secret, unrendered text.#1517
Open
VaporeonMega-git wants to merge 2 commits intoValour-Software:mainfrom
Open
Fix the ability to send messages with secret, unrendered text.#1517VaporeonMega-git wants to merge 2 commits intoValour-Software:mainfrom
VaporeonMega-git wants to merge 2 commits intoValour-Software:mainfrom
Conversation
SpikeViper
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users could send messages with hidden text like [this](), which would be rendered as an empty string with a link referring to this. Custom css can't be used to reveal this text because the hidden text is in the href attribute rather than the text. It's a nightmare for moderation if members communicate like this since the only way to see it is to use the copy text button.
The fix is to insert a backslash into the message between ] and (). This prevents the text from being rendered as a link with no text, and doesn't appear to have a backslash inserted.
Also, there was a similar replace already present which changes []( to (. The problem with this was that users could just type [][]( and it would be changed to [](.
The fix is to instead replace []( with []\(. This will appear as [](, but the backslash breaks up the [] and (.