Feature: Add events to differentiate creations vs updates#1519
Open
tystuyfzand wants to merge 2 commits intoValour-Software:mainfrom
Open
Feature: Add events to differentiate creations vs updates#1519tystuyfzand wants to merge 2 commits intoValour-Software:mainfrom
tystuyfzand wants to merge 2 commits intoValour-Software:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new event suffix "Create" to planet models which can differentiate between items being created and just being updated, while (hopefully) maintaining compatibility by simply calling
model.Syncby default.This will make future hooks and bots able to specifically listen for creation events instead of having to differentiate between a model creation vs update by using the snowflake/timestamp/cache, allowing for better control over actions.
Note: I haven't been able to fully test this, and would appreciate anyone who has gotten Valour set up locally to help with this. I did some digging into the code to try to find hook locations, and it appears that it's only in the Node model, but that could be incorrect.