Move sol usertype registration to dedicated TU#2099
Open
ishitatsuyuki wants to merge 1 commit intoValveSoftware:masterfrom
Open
Move sol usertype registration to dedicated TU#2099ishitatsuyuki wants to merge 1 commit intoValveSoftware:masterfrom
ishitatsuyuki wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
The sol2 header is massive. Instantiating a static in every file also has implications on binary size. Move usertype registration to a dedicated translation unit, per official advice [1]. [1]: https://sol2.readthedocs.io/en/latest/compilation.html
Author
|
CI time 4m51s -> 3m45s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sol2 header is massive. Instantiating a static in every file also has implications on binary size.
Move usertype registration to a dedicated translation unit, per official advice 1.