sdl: ignore synthetic keyup events during key repeat#2103
Open
awsms wants to merge 1 commit intoValveSoftware:masterfrom
Open
sdl: ignore synthetic keyup events during key repeat#2103awsms wants to merge 1 commit intoValveSoftware:masterfrom
awsms wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
On the SDL backend, holding a key can generate KEYUP events even while the key is still physically held. Gamescope already ignores repeated KEYDOWN events, but these KEYUPs were still forwarded to wlserver, causing spurious release notifications. Filter SDL_KEYUP by checking SDL_GetKeyboardState(): if SDL still reports the scancode as pressed, treat the KEYUP as synthetic repeat noise and drop it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the SDL backend, holding a key can generate KEYUP events even while the key is still physically held.
Gamescope already ignores repeated KEYDOWN events, but these KEYUPs were still forwarded to wlserver, causing spurious release notifications.
Filter SDL_KEYUP by checking SDL_GetKeyboardState(): if SDL still reports the scancode as pressed, treat the KEYUP as synthetic repeat noise and drop it.
edit: fixes #1183 (comment)