Replace almost all pp.Combine() into pp.Regex()#60
Open
embar- wants to merge 147 commits intoVanderhoof:masterfrom
Open
Replace almost all pp.Combine() into pp.Regex()#60embar- wants to merge 147 commits intoVanderhoof:masterfrom
embar- wants to merge 147 commits intoVanderhoof:masterfrom
Conversation
… new parser class, tests rework WIP
- Integrated `prepare_text_for_dbml` into `default_to_str` for consistent handling of special characters in DBML column strings. - Updated the test suite to include a new test case for handling binary string input (`b'0'`).
…default-escapse Fix bug in DBML column default rendering with single quotes
…brackets fix: line breaks in column and index options are allowed (Vanderhoof#48)
…tion fix: table elements may go in any order (Vanderhoof#49)
feat: TableGroup notes support
Feat/table group color
fix: quote tablegroup and project name on dbml render Vanderhoof#46
Develop into master
…_other_index_types feat(indexes): support all Postgresql index types
Owner
|
So I took a look, there are 19 failing tests after applying this PR. But what concerns me most is that using pp.Regex negatively impacts readability of the code. After all, why use Pyparsing then, if we end up with regex's anyway. But you are right, current PyDBML performance is terrible. But thanks a lot for the contribution! I'll have to invest some time into the problem, and will use your changes as a basis |
Author
|
Regarding better readability – you can always add comments for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Majority of pp.Combine() are replaced into pp.Regex() for optimization.
Only this one line is not changed:
PyDBML/pydbml/definitions/enum.py
Line 56 in 2bf015c
This will contribute to #59 solving
Some metrics: