Implemented-Borrow -request- actions by VaniThapar · Pull Request #33 · VaniThapar/UnityLend

VaniThapar · 2024-03-04T15:24:38Z

Implemented the following features:

-Have a separate table for borrowing request with all the attributes of borrowing and map with the user table with foreign key
-Validation should be there at service layer for borrow request (i.e - The monthly emi should not be more than half of the monthly income of borrower)
-If a borrowing request is not passing the validations, Return the error message to the UI.
-If borrowing request is validated, Return the success message to the user and insert into DB.
-Think how the mapping of community to borrowing request will happen (User to borrowing request or Community to borrowing request)

create user and community features

Get communities associated with a given userId

User and community feature

gitguardian · 2024-03-04T15:24:47Z

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9696177	Triggered	Username Password	`1c8facd`	src/main/resources/application.properties	View secret
9696177	Triggered	Username Password	`07d5635`	src/main/resources/application.properties	View secret
9696177	Triggered	Username Password	`08919bf`	src/main/resources/application.properties	View secret
9696177	Triggered	Username Password	`6b99b8f`	src/main/resources/application.properties	View secret
9696177	Triggered	Username Password	`faf9a17`	src/main/resources/application.properties	View secret
9696177	Triggered	Username Password	`8930a4d`	src/main/resources/application.properties	View secret
9696178	Triggered	Generic Password	`08919bf`	src/main/java/com/educare/unitylend/dao/UserRepository.java	View secret
9696178	Triggered	Generic Password	`046509a`	src/main/java/com/educare/unitylend/dao/UserRepository.java	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

educare-kumapuru · 2024-03-11T15:16:25Z

src/main/java/com/educare/unitylend/dao/BorrowRequestRepository.java

+@Mapper
+@Repository
+public interface BorrowRequestRepository {
+


Add method to fetch borrow request based on community_id, This is required for lenders page.

Modify the schema to have a borrow request multiple communities, You can have a separate table which can have the mapping of community to Borrow request.

educare-kumapuru · 2024-03-11T15:21:05Z

src/main/java/com/educare/unitylend/model/BorrowRequest.java

@@ -12,12 +10,27 @@
 @NoArgsConstructor
 @AllArgsConstructor
 public class BorrowRequest {


Add @DaTa on the DataClass, Post that there will be no need to add @Getter and @Setter tag on every variable in the class.

Make the change to have many to many community to borrow request map. In this particular POJO this should have List

educare-kumapuru · 2024-03-11T15:27:38Z

src/main/java/com/educare/unitylend/dao/BorrowRequestRepository.java

+            "FROM Borrow_Request " +
+            "JOIN Community ON Borrow_Request.CommunityID = Community.CommunityId " +
+            "WHERE Borrow_Request.BorrowerId = #{userId}")
+    List<String> getBorrowRequestByUserId(@Param("userId") String userId);


Based on the functionality, The function name should be
getCommunitiesForWhichBorrowRequestRaisedByUser()

educare-kumapuru · 2024-03-11T15:28:35Z

src/main/java/com/educare/unitylend/service/BorrowRequestService.java

+
+public interface BorrowRequestService {
+
+    List<String> getRequestedCommunitiesByUserId(String userId) throws ServiceException;


The function name should be
getCommunitiesForBorrowrequestRaisedByUser()

educare-kumapuru · 2024-03-11T15:30:09Z

src/main/java/com/educare/unitylend/service/BorrowRequestService.java

+
+    List<String> getRequestedCommunitiesByUserId(String userId) throws ServiceException;
+
+    boolean raiseBorrowRequestByUserId(String userId, BorrowRequest borrowRequest) throws ServiceException;


The function name should be validateBorrowRequest.

I don't think that there is any need to pass userId as BorrowRequest object would already be having the borrower details.

educare-kumapuru · 2024-03-11T15:32:26Z

src/main/java/com/educare/unitylend/service/BorrowRequestService.java

+
+    boolean raiseBorrowRequestByUserId(String userId, BorrowRequest borrowRequest) throws ServiceException;
+
+    void createBorrowRequest(BorrowRequest borrowRequest) throws ServiceException;


This function should also return boolean value, Whether the borrow request is created successfully in the DB or not.

educare-kumapuru · 2024-03-11T15:33:35Z

src/main/java/com/educare/unitylend/service/impl/BorrowRequestServiceImpl.java

+    private BorrowRequestRepository borrowRequestRepository;
+    public List<String> getRequestedCommunitiesByUserId(String userId) throws ServiceException{
+        List<String> communities=borrowRequestRepository.getBorrowRequestByUserId(userId);
+        System.out.println(communities);


Do not use System.out.println instead use log.error, log.info or log.debug

educare-kumapuru · 2024-03-11T15:34:23Z

src/main/java/com/educare/unitylend/service/impl/BorrowRequestServiceImpl.java

+    }
+
+    public void createBorrowRequest(BorrowRequest borrowRequest) {
+        borrowRequestRepository.createBorrowRequest(borrowRequest);


You should have a try catch block,
If any error is encountered, Return false.

educare-kumapuru · 2024-03-11T15:35:31Z

src/main/java/com/educare/unitylend/service/impl/BorrowRequestServiceImpl.java

+    public boolean raiseBorrowRequestByUserId(String userId, BorrowRequest borrowRequest) throws ServiceException {
+        try {
+            // Assuming returnPeriod is in days
+            BigDecimal monthlyInterestRate = new BigDecimal("50.0").divide(new BigDecimal(12 * 100), 10, RoundingMode.HALF_UP);


Move all the constants used to the start of the class, i.e public static final Integer MONTHS_IN_YEAR = 12.

Add interest_rate in the BorrowRequest Object

Add loan tenure in BorrowRequest object.

The validation method here should just calculate the monthly EMI and then validate based on the user income if the user will be able to pay the amount or not, By checking if the user income is double of the EMI or not.

And for calculating the EMI you should have different function calculateEMI(PrincipalAmount, loanPaymentTenure, InterestRate) and this function should utilize that.

educare-kumapuru · 2024-03-11T15:45:43Z

src/main/java/com/educare/unitylend/controller/BorrowRequestController.java

+public class BorrowRequestController extends BaseController{
+    BorrowRequestService borrowRequestService;
+    @GetMapping("/{userId}")
+    public ResponseEntity<List<String>> getAllCommunities(@PathVariable String userId) throws ControllerException {


The function name should be getCommunitiesForUser()

There should be a method for getting the borrowRequest for a given UserId, Community.

And one for Administration purpose to get all the Borrowrequests.

Prathyusha5c0 and others added 17 commits February 25, 2024 21:14

Move the DB schema under resources folder

25f4d09

Resolved Issue 9, 10 & 12

08919bf

Resolved Issue 9, 10 & 12

86d1fcb

Resolved Issue 9, 10 & 12

07d5635

Resolved Issue 9, 10 & 12

72b2930

Resolved Issue 9, 10 & 12

7de0820

Merge remote-tracking branch 'origin/prathyusha' into prathyusha

d1a4494

Resolved Issue 9, 10 & 12

cb66107

Resolved Issues 9, 10 & 12

046509a

Merge remote-tracking branch 'origin/prathyusha' into prathyusha

656e2c5

Merge remote-tracking branch 'origin/prathyusha' into prathyusha

488cf2e

Merge pull request #18 from Prathyusha5c0/prathyusha

53cb031

create user and community features

Get communities associated with a given userId

faf9a17

Merge remote-tracking branch 'origin/prathyusha' into prathyusha

4f58065

Merge pull request #24 from Prathyusha5c0/prathyusha

8930a4d

Get communities associated with a given userId

Merge pull request #25 from VaniThapar/user-and-community-feature

6b99b8f

User and community feature

added-borrow-request-features

1c8facd

VaniThapar requested a review from educare-kumapuru March 4, 2024 15:24

added-borrow-request-features

0408170

educare-kumapuru requested changes Mar 11, 2024

View reviewed changes


		public interface BorrowRequestService {

		List<String> getRequestedCommunitiesByUserId(String userId) throws ServiceException;


		List<String> getRequestedCommunitiesByUserId(String userId) throws ServiceException;

		boolean raiseBorrowRequestByUserId(String userId, BorrowRequest borrowRequest) throws ServiceException;


		boolean raiseBorrowRequestByUserId(String userId, BorrowRequest borrowRequest) throws ServiceException;

		void createBorrowRequest(BorrowRequest borrowRequest) throws ServiceException;

Conversation

VaniThapar commented Mar 4, 2024

Uh oh!

gitguardian bot commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gitguardian bot commented Mar 4, 2024 •

edited

Loading