Open
Conversation
Collaborator
NehaKariya0309
left a comment
NehaKariya0309
left a comment
There was a problem hiding this comment.
@ShellyAgg Custom Exceptions to be used instead of Exception class. Better to use the same exception class in corresponding subpackages.
| } | ||
| } | ||
|
|
||
| @GetMapping("/user/{userId}/target-amount/{amount}") |
Collaborator
There was a problem hiding this comment.
Here , all apis should have community id filter applied to it, because on a community landing page , only requests of that community should be displayed.
Instead of Path Variable User id, community id should be used.
Collaborator
There was a problem hiding this comment.
These are APIs for users, and will create separate APIs for the community lending page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.