Fix/stats webhook improvements#455
Open
Mac-5 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #357
closes #358
closes #359
closes #360
Issue 1 — Stats: feeApr from pool fees
stats.worker.ts: replaced the approximation volume24h × (feeTier/1_000_000) with a sum of actual swap.feeAmount fields from 24h swaps, multiplied by the token price, then annualised. Tests updated with feeAmount on mock swaps and two new assertions verifying the real-fee-based result.
Issue 2 — Webhooks: large_swap threshold from env
webhooks.service.ts: largeSwapUsd default now reads LARGE_SWAP_THRESHOLD_USD from the environment (parseFloat(process.env.LARGE_SWAP_THRESHOLD_USD ?? '10000')). Explicit caller value still takes precedence.
Issue 3 — Webhooks: retry failed webhook deliveries
Issue 4 — Webhooks: webhook signature HMAC verification
webhook.types.ts: verifyWebhookSignature(body, signature, secret) exported — uses timingSafeEqual with a length pre-check and guards against empty/invalid inputs. POST /webhooks/verify-signature endpoint exposed in the controller.
Related issue
Type of change
Checklist