Fix/devex security platform improvements#459
Open
dami-005 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Closes #369
closes #370
closes #371
closes #372
Type of change
FILES CHANGED
What was done
Docker Compose (api + web + redis + postgres)
Created a root-level docker-compose.yml with all four services. Added apps/api/Dockerfile (multi-stage NestJS build) and apps/web/Dockerfile (Next.js standalone build), plus .dockerignore to exclude node_modules, .next, .git, etc. from the build context.
CI e2e job with test database
Added an e2e job to .github/workflows/ci.yml that spins up a dedicated swyft_e2e Postgres database and Redis, runs migrations against it, then executes pnpm --filter api test:e2e. Also added the missing db:migrate:deploy script to root package.json (referenced by existing CI jobs but never defined).
Swagger document transactions endpoint
Converted SubmitTransactionDto and TransactionResult from plain interfaces to decorated classes (@ApiProperty, @IsString, @isnotempty). Added @ApiBody, @apiresponse (200/400/401/422) decorators to the POST /transactions handler so the endpoint is fully documented in the generated OpenAPI spec.
JWT guard on portfolio mutations
Added @UseGuards(JwtAuthGuard) and @ApiBearerAuth() to TransactionsController — since submitting a signed XDR transaction is a portfolio-mutating operation (it creates/closes positions and executes swaps). The controller spec was updated to override the guard with a pass-through so unit tests continue working without a real JWT.
Checklist