Skip to content
This repository was archived by the owner on Mar 12, 2023. It is now read-only.

Fix download URLs with spaces#11

Open
jav76 wants to merge 5 commits intoVazkii:masterfrom
jav76:dev
Open

Fix download URLs with spaces#11
jav76 wants to merge 5 commits intoVazkii:masterfrom
jav76:dev

Conversation

@jav76
Copy link
Copy Markdown

@jav76 jav76 commented May 13, 2022

There was an issue where if any mod name defined in minecraftinstance.json had a space in it, the name would get directly converted to a download URL string that includes the space. This would result in a broken link and would not download properly. These changes will replace all spaces in the download URL with the proper "%20" space character.
For more info see #2025.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant