Skip to content

Add vertex search tool with integration tests#73

Merged
amrit110 merged 7 commits intomainfrom
add_vertex_search_tool
Mar 8, 2026
Merged

Add vertex search tool with integration tests#73
amrit110 merged 7 commits intomainfrom
add_vertex_search_tool

Conversation

@amrit110
Copy link
Member

@amrit110 amrit110 commented Mar 2, 2026

Summary

Clickup Ticket(s): Link(s) if applicable.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test improvements
  • 🔒 Security fix

Changes Made

  • Add a new tool that allows for searching over custom knowledge base using vertex AI
  • Add tests including a complete integration test using a dummy database
  • Add a notebook showing how the custom knowledge base can be setup and integrated

Testing

  • Tests pass locally (uv run pytest tests/)
  • Type checking passes (uv run mypy <src_dir>)
  • Linting passes (uv run ruff check src_dir/)
  • Manual testing performed (describe below)

Manual testing details:

Screenshots/Recordings

Related Issues

Deployment Notes

Checklist

  • Code follows the project's style guidelines
  • Self-review of code completed
  • Documentation updated (if applicable)
  • No sensitive information (API keys, credentials) exposed

@amrit110 amrit110 self-assigned this Mar 2, 2026
@amrit110 amrit110 added enhancement New feature or request tests Add or update unit or integration tests labels Mar 2, 2026
Copy link
Collaborator

@lotif lotif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is the user supposed to run this script? I don't see it on any README or notebook.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, user won't run this. We will run it for the participants. I'll add another README or something later for internal documentation.

@amrit110 amrit110 merged commit 89daffd into main Mar 8, 2026
2 of 3 checks passed
@amrit110 amrit110 deleted the add_vertex_search_tool branch March 8, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request tests Add or update unit or integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants