Try multiple identification methods#1
Merged
Vecvec merged 5 commits intoVecvec:masterfrom Nov 6, 2025
Merged
Conversation
Owner
|
This is a very sensible, for some reason I misread it as different graphics APIs would only offer some identification and had not considered the same for the APIs oidn uses internally (and that it might report them differently too). I would prefer if |
Contributor
Author
|
Oh, didn't know you could just tell git to ignore files locally. |
Owner
I think there are multiple ways to do it. Personally, I like adding |
Vecvec
approved these changes
Nov 6, 2025
Owner
Vecvec
left a comment
Vecvec
left a comment
There was a problem hiding this comment.
Looks good, and extendable too.
Owner
|
Thank you very much for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my particular configuration, on vulkan, the creation of a shared OIDN device by UUID fails, while it works just fine with LUID.
In general the OIDN docs state that ideally multiple identification methods should be attempted, as some drivers can report mismatching IDs for the same physical device.