Unhardcode IS_STANDALONE in web build#4238
Open
pointydev wants to merge 1 commit into
Open
Conversation
Initial edit, unsure if anywhere else needs editing
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the web build script to import and use a dynamic IS_STANDALONE flag instead of a hardcoded value in the common build options. A review comment suggests explicitly overriding this flag to false for extension and userscript targets to prevent them from inheriting an incorrect standalone status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial edit, unsure if anywhere else needs editing.
Conversation: https://discord.com/channels/1015060230222131221/1015063227299811479/1507870884172660897
Thanks,
pointy