Fix newline characters not being typed into textareas#61
Open
kevinsimler wants to merge 2 commits intoVibiumDev:mainfrom
Open
Fix newline characters not being typed into textareas#61kevinsimler wants to merge 2 commits intoVibiumDev:mainfrom
kevinsimler wants to merge 2 commits intoVibiumDev:mainfrom
Conversation
Contributor
|
to fix this issue, should we be sending \uE006 instead? including a link to where to relavent sections of the WebDriver or WebDriver BiDi spec would also be helpful to folks reading this later. |
WebDriver BiDi requires carriage return (\r) to produce the Enter key, not newline (\n). Text containing \n was being typed without line breaks. - Add NormalizeKeyChar helper in internal/bidi/keys.go - Apply conversion in both input.go (CLI) and router.go (WebSocket API) - Add newline tests for JS async API and CLI
Rename NormalizeKeyChar to ConvertToKeyChar to better reflect its purpose: mapping string literal characters (e.g. \n) to their WebDriver BiDi keyboard equivalents (e.g. \uE006 Return key). Also switch from \r to the canonical WebDriver Return key code.
kevinsimler
force-pushed
the
textarea-newlines
branch
from
70de1bd to
b2eeaae
Compare
Author
|
I think you're right that Addressed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebDriver BiDi requires carriage return (\r) to produce the Enter key, not newline (\n). Text containing \n was being typed without line breaks / line breaks were being dropped.