Fix #62: Resolve clicker binary path in ES Module context#75
Open
bluerook2000 wants to merge 1 commit intoVibiumDev:mainfrom
Open
Fix #62: Resolve clicker binary path in ES Module context#75bluerook2000 wants to merge 1 commit intoVibiumDev:mainfrom
bluerook2000 wants to merge 1 commit intoVibiumDev:mainfrom
Conversation
Use createRequire from 'module' as fallback when native require.resolve is unavailable (ESM context). This fixes the binary resolution for projects using "type": "module" in package.json. Fixes VibiumDev#62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #62 — Vibium fails to locate the clicker binary when used in ESM projects (
"type": "module"in package.json).Problem
The
getClickerPath()function usedrequire.resolve()to find the platform-specific binary package. In ESM context,requireis not available, causing the resolution to fail with:Solution
Added a
resolvePackageJson()helper that:require.resolve()first (works in CJS)createRequire()from themodulebuiltin (works in ESM)The
createRequireapproach creates a require function anchored toprocess.cwd(), which correctly resolves packages from the project'snode_modules.Verification
tsupbuild succeeds for both CJS and ESM formatscreateRequirefallback (tsup transformsrequire→__requirein ESM, so the CJS branch naturally skips)require.resolvepath still worksFiles Changed
clients/javascript/src/clicker/binary.ts— Added ESM-compatible package resolution