Fix #64: Improve timeout error messages in find()#76
Open
bluerook2000 wants to merge 1 commit intoVibiumDev:mainfrom
Open
Fix #64: Improve timeout error messages in find()#76bluerook2000 wants to merge 1 commit intoVibiumDev:mainfrom
bluerook2000 wants to merge 1 commit intoVibiumDev:mainfrom
Conversation
Two changes: 1. BiDi client handleResponse: Safely stringify error/message fields that may not be strings, preventing '[object Object]: undefined' 2. Vibe.find(): Catch BiDi errors and re-throw as TimeoutError with the selector, timeout duration, and original error message. This gives users clear, actionable error messages like: 'Timeout after 1000ms waiting for "#does-not-exist": ...' instead of the unhelpful '[object Object]: undefined'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #64 — timeout errors from
find()were showing as[object Object]: undefinedinstead of helpful messages.Changes
1.
clients/javascript/src/bidi/client.tshandleResponse(): Safely stringifyresponse.errorandresponse.messagefields that may not be strings, preventing the[object Object]: undefinedoutput.2.
clients/javascript/src/vibe.tsfind(): Catch BiDi errors and re-throw asTimeoutError(fromutils/errors.ts) when the error indicates a timeout or missing element. This produces clear messages like:Testing
tsc --noEmit)npm run build)find() times out for non-existent elementandtimeout error message is clear) should now pass since:/timeout/iregex)includes('#nonexistent-element-xyz')check)