vmuser: support target ref for VMAnomaly#2142
Open
AndrewChubatiuk wants to merge 1 commit intomasterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 13 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:18">
P3: This changelog entry attributes a VMUser feature to `vmanomaly`; it should reference `vmuser` so readers can navigate to the correct resource docs.
(Based on your team's feedback about keeping docs links and metadata accurate.) [FEEDBACK_USED]</violation>
</file>
<file name="api/operator/v1/vmanomaly_types.go">
<violation number="1" location="api/operator/v1/vmanomaly_types.go:435">
P1: `ProbePort()` now targets monitoring pull port (default `8080`) for health probes, but VMAnomaly health checks are served on the server port (default `8490`), which can break liveness/readiness probes.</violation>
</file>
Tip: cubic used a learning from your PR history. Let your coding agent read cubic learnings directly with the cubic MCP.
Fix all with cubic
0a254b4 to
498be6b
Compare
498be6b to
3cc52dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2141
Summary by cubic
Enable
VMUsertargetRefs to point toVMAnomalysoVMAuthcan route requests to it. Adds a headless Service and default ports so service URLs resolve even when not specified.VMUsertargetRef now acceptsVMAnomaly;VMAuthresolves its URL viaAsURL.Service, sets StatefulSetserviceName, and removes theServiceon delete.monitoring.pull.port=8080,server.port=8490; addsPort,ProbePort, andAsURL.Written for commit 3cc52dd. Summary will update on new commits.