Skip to content

vmuser: support target ref for VMAnomaly#2142

Open
AndrewChubatiuk wants to merge 1 commit intomasterfrom
vmanomaly-target-ref
Open

vmuser: support target ref for VMAnomaly#2142
AndrewChubatiuk wants to merge 1 commit intomasterfrom
vmanomaly-target-ref

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk commented May 9, 2026

fixes #2141


Summary by cubic

Enable VMUser targetRefs to point to VMAnomaly so VMAuth can route requests to it. Adds a headless Service and default ports so service URLs resolve even when not specified.

  • New Features
    • VMUser targetRef now accepts VMAnomaly; VMAuth resolves its URL via AsURL.
    • Creates a headless Service, sets StatefulSet serviceName, and removes the Service on delete.
    • Defaults: monitoring.pull.port=8080, server.port=8490; adds Port, ProbePort, and AsURL.
    • Updates CRD enums, API docs, changelog, and tests.

Written for commit 3cc52dd. Summary will update on new commits.

@AndrewChubatiuk AndrewChubatiuk requested a review from vrutkovs as a code owner May 9, 2026 14:35
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 13 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:18">
P3: This changelog entry attributes a VMUser feature to `vmanomaly`; it should reference `vmuser` so readers can navigate to the correct resource docs.

(Based on your team's feedback about keeping docs links and metadata accurate.) [FEEDBACK_USED]</violation>
</file>

<file name="api/operator/v1/vmanomaly_types.go">

<violation number="1" location="api/operator/v1/vmanomaly_types.go:435">
P1: `ProbePort()` now targets monitoring pull port (default `8080`) for health probes, but VMAnomaly health checks are served on the server port (default `8490`), which can break liveness/readiness probes.</violation>
</file>

Tip: cubic used a learning from your PR history. Let your coding agent read cubic learnings directly with the cubic MCP.
Fix all with cubic

Comment thread api/operator/v1/vmanomaly_types.go
Comment thread docs/CHANGELOG.md Outdated
@AndrewChubatiuk AndrewChubatiuk force-pushed the vmanomaly-target-ref branch 4 times, most recently from 0a254b4 to 498be6b Compare May 9, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Target Ref support for vmanomaly

2 participants