feat: include finished group results on early exit#1025
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019eda26-9690-706a-aa5b-d0e12f8eb290 Co-authored-by: Amp <amp@ampcode.com>
WalkthroughAdds an ChangesincludeFinishedResultsOnEarlyExit for Parallel Groups
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/frontend/src/components/menu/addons/_components/addon-fetching-behavior.tsx`:
- Line 8: The relative import statement for Switch on line 8 is missing the
required `.js` extension per the repository's NodeNext import resolution rules.
Update the import path from '../../../ui/switch' to
'../../../ui/switch/index.js' to explicitly specify the full path to the module
entry point, since the switch directory contains an index.tsx that re-exports
the Switch component.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: e92282a9-4d28-4cd5-b08d-1edeb3aff2da
📒 Files selected for processing (9)
packages/core/src/db/schemas.tspackages/core/src/parser/streamExpression.tspackages/core/src/streams/fetcher.tspackages/core/src/streams/filterer.tspackages/core/src/streams/precomputer.tspackages/core/src/utils/config.tspackages/docs/content/docs/guides/groups.mdxpackages/frontend/src/components/menu/addons/_components/addon-fetching-behavior.tsxpackages/frontend/src/context/userData.tsx
| import { TextInput } from '../../../ui/text-input'; | ||
| import { Combobox } from '../../../ui/combobox'; | ||
| import { IconButton } from '../../../ui/button'; | ||
| import { Switch } from '../../../ui/switch'; |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the concrete target file so the final import path uses the correct .js entry.
fd -i 'switch\.(ts|tsx|js|jsx)$' packages/frontend/src/components/ui
fd -i 'index\.(ts|tsx|js|jsx)$' packages/frontend/src/components/ui/switchRepository: Viren070/AIOStreams
Length of output: 234
🏁 Script executed:
cat packages/frontend/src/components/ui/switch/index.tsxRepository: Viren070/AIOStreams
Length of output: 89
Use the correct path with .js extension for the relative import.
Line 8 adds a relative import without an explicit .js extension, which violates the repository's NodeNext import rule for package-internal relative paths. Since the switch directory contains an index.tsx that re-exports from switch.tsx, the import should resolve to the index file.
Suggested patch
-import { Switch } from '../../../ui/switch';
+import { Switch } from '../../../ui/switch/index.js';Per the coding guidelines, relative imports inside a package must include the .js extension (TypeScript NodeNext resolution), specifying the full path to the module entry point.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import { Switch } from '../../../ui/switch'; | |
| import { Switch } from '../../../ui/switch/index.js'; |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@packages/frontend/src/components/menu/addons/_components/addon-fetching-behavior.tsx`
at line 8, The relative import statement for Switch on line 8 is missing the
required `.js` extension per the repository's NodeNext import resolution rules.
Update the import path from '../../../ui/switch' to
'../../../ui/switch/index.js' to explicitly specify the full path to the module
entry point, since the switch directory contains an index.tsx that re-exports
the Switch component.
Source: Coding guidelines
Summary
Suggested follow-up tests
Verification
Note: commands ran under Node v22.21.0, so pnpm printed the repo's Node >=24 engine warning.
Summary by CodeRabbit
Release Notes
New Features
Documentation