VCST-5163: Stable 15 — Export (platform 3.1039.0)#102
Merged
Conversation
- Bump VirtoCommerce.Platform.* to 3.1039.0 and Wave-1 deps to released versions; module version -> 3.1002.0. - Built green via vc-build Compress against nuget.org. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…541) Extract the per-object export block (clone + tabular/enumerable handling + error capture) into a private ExportObject method, lowering Export's cognitive complexity (21->under 15) and cyclomatic complexity (11->under 10). Behavior unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Stable 15 (Wave 2). Platform 3.1039.0 + Wave-1 deps (nuget.org). Branch actualized with latest dev.
vc-build Compressgreen.🤖 Generated with Claude Code
Note
Medium Risk
Public
IDataExportersignature change may break other modules, and the platform upgrade affects Hangfire export jobs and download authorization semantics.Overview
Bumps the Export module for Stable 15:
module.manifestand package references target platform 3.1039.0, VirtoCommerce.Assets 3.1005.0, and Microsoft.AspNetCore.Mvc.NewtonsoftJson 10.0.9.Export cancellation now uses
System.Threading.CancellationTokenonIDataExporter.Exportinstead of the platformICancellationToken.ExportJobpasses Hangfire’scancellationToken.ShutdownTokendirectly, droppingJobCancellationTokenWrapper.DataExporterpulls per-item clone/write/error handling into a privateExportObjectmethod; behavior is unchanged.The export download action keeps authorizing with the legacy
PlatformConstants.Security.Permissions.PlatformExportconstant under#pragma warning disable VC0015, with a comment that the permission moved to BackupRestore but the constant remains for backward compatibility without a module dependency.Reviewed by Cursor Bugbot for commit 53e60cb. Bugbot is set up for automated code reviews on this repo. Configure here.
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-5163
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Export_3.1003.0-pr-102-53e6.zip