Draft
Conversation
Added generated GraphSimulation compatibility validation in src/compiled_model.jl (line 68). Compiled scripts now embed a model signature and fail early if called with a different mapping/model set or wrong same-rate vs multirate mode. Added the compatibility signature to generated script headers for inspection. Hoisted multirate per-node setup out of the timestep loop in src/compiled_model.jl (line 338): node metadata, model, model spec, and model clock are now generated as stable locals like _mr_Leaf_carbon_assimilation_model_clock. Kept temporal input resolution, meteo sampling, output publishing, and requested exports delegated to the existing runtime helpers. Kept the GraphSimulation(...; type_promotion=...) constructor fix in src/mtg/GraphSimulation.jl (line 37). Added tests for compatibility validation and multirate hoisting in test/test-compiled-model.jl (line 113).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mode=:readable | :fastto compiled model generation and preserveStatus-backed execution semanticsTesting
ModelMappingcoverage passesgit diff --checkpasses