Fix for Magento to work with multi currency stores.#1211
Open
Ddcdom wants to merge 1 commit intoVivaPayments:masterfrom
Open
Fix for Magento to work with multi currency stores.#1211Ddcdom wants to merge 1 commit intoVivaPayments:masterfrom
Ddcdom wants to merge 1 commit intoVivaPayments:masterfrom
Conversation
…otal to Viva instead of grand total. Base grand total is store base currency.
Contributor
|
This modification would be right in case you accept only transactions in the stores default currency. However, in case you would allow transactions in any used store currency (recommended setup, using multiple Viva accounts at the moment), this modification would be wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to correctly work with multi currency stores. Passes base grand total to Viva instead of grand total. Base grand total is store base currency.