fix(provider): mark DeepSeek models as BYOK#162
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the DeepSeek chat model metadata returned to VS Code so the models are explicitly classified as BYOK (Bring Your Own Key) via LanguageModelChatInformation.isBYOK, aligning with new VS Code logic that differentiates BYOK from Copilot/CAPI-backed models.
Changes:
- Extend the local
ModelPickerChatInformationmetadata type to includeisBYOK. - Set
isBYOK: trueon the model chat info objects returned bytoChatInfo.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isBYOK: trueso new VS Code BYOK-aware logic classifies the provider correctly.Why
VS Code now distinguishes BYOK models from Copilot/CAPI models using
LanguageModelChatInformation.isBYOK. DeepSeek requests are served with the user supplied API key, so the provider should opt into that signal.Upstream VS Code PR: microsoft/vscode#321090
Validation
npm run format:checknpm run compile