You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a small TypeScript safety fix. No public API or package behavior was changed.
Summary by cubic
Fixes a TypeScript compile error in the Netlify Functions example by safely accessing the optional logger. Uses context?.logger?.info(...) so builds succeed when a logger is unavailable.
Written for commit d26e97b. Summary will update on new commits.
Summary by CodeRabbit
Bug Fixes
Improved weather tool reliability by preventing errors when optional logging context is unavailable.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The Netlify Functions example fails to compile because
context.loggercan be undefined.
TypeScript reports:
'context.logger' is possibly 'undefined'What is the new behavior?
The logger is accessed using optional chaining:
This allows the Netlify Functions example to compile even when the logger
is unavailable.
Testing
Ran:
The build completed successfully.
Notes for reviewers
This is a small TypeScript safety fix. No public API or package behavior was changed.
Summary by cubic
Fixes a TypeScript compile error in the Netlify Functions example by safely accessing the optional logger. Uses
context?.logger?.info(...)so builds succeed when a logger is unavailable.Written for commit d26e97b. Summary will update on new commits.
Summary by CodeRabbit