[WIP] Add GitHub Actions artifact upload command #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegration - Fix defer in test loop using t.Setenv - Add artifact name sanitization to prevent path traversal - Use cmd.Context() for proper cancellation propagation - Increase HTTP timeout to 10 minutes for large artifacts - Fix Zip Slip vulnerability with path validation - Add size limit check (1GB max) for artifact downloads - Fix defer in loop for temp directory cleanup - Fix ignored JSON marshal error in output - Add authentication support via VULNETIX_API_KEY - Add txnID validation with alphanumeric regex - Fix file handle closing with proper error handling - Use safe file permissions (0644/0755) instead of zip entry permissions Co-authored-by: 0x73746F66 <93355168+0x73746F66@users.noreply.github.com>
- Test sanitizeArtifactName function with various inputs - Test ListArtifacts with mock HTTP server - Test Zip Slip vulnerability protection - Test valid zip extraction with safe permissions - Test artifact size limit enforcement - Test successful artifact download and extraction - Test validateTxnID function with various inputs - Test authentication header injection - Test transaction initiation with mock server - Test artifact upload with multipart form data - Test transaction and artifact status retrieval - Test error handling for invalid inputs Co-authored-by: 0x73746F66 <93355168+0x73746F66@users.noreply.github.com>
- Move artifact name sanitization regex to package-level variable - Move transaction ID validation regex to package-level variable - Remove redundant file mode condition in extractZip These changes improve performance by compiling regex patterns once at package initialization instead of on every function call. Co-authored-by: 0x73746F66 <93355168+0x73746F66@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.