docs(tradable): explain component check#858
Merged
TobiTenno merged 4 commits intoWFCD:masterfrom Feb 23, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA documentation block is added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TobiTenno
requested changes
Feb 12, 2026
TobiTenno
reviewed
Feb 12, 2026
Clarity-89
changed the title
…items The tradableConditions function was blocking all Prime items with weapon/warframe types (Rifle, Pistol, Melee, Warframe, etc.), making 148 Prime items incorrectly untradable. Most of these (143) have tradable components and represent tradable sets. Replace the blanket block with a three-layer approach: 1. Explicit override map for edge cases (Baro weapons, quest-locked items) 2. Component-based detection as the default fallback 3. Items with no tradable components remain untradable (Founders items) Also simplifies the Wraith regex from Wraith\w|\wWraith to just Wraith, which properly matches item names with spaces (e.g. "Strun Wraith"). Adds 25 unit tests for the tradable function covering all cases.
Update JSDoc to use plain Object types instead of import() syntax to satisfy valid-jsdoc rule. Remove Wraith name-match test that was left over after reverting the Wraith regex change.
Revert component-check approach per review feedback. Built Prime items are not directly tradable; only their parts are. Components get their own tradable flag. To determine if a Prime set is tradable, check item.components for parts with tradable: true.
TobiTenno
force-pushed
the
fix/tradable-status
branch
from
dbf675b to
48eb63b
Compare
TobiTenno
approved these changes
Feb 23, 2026
Collaborator
|
🎉 This PR is included in version 1.1272.123 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And a comment to clarify how the tradable status is computed.
Considerations
Summary by CodeRabbit