#120 feat: add backend REST endpoint POST /settlements/:id/execute Repo Avatar WHEELBACK/COMEBACKHERE#138
Merged
Merged
Conversation
feat: add backend REST endpoint POST /settlements/:id/execute
feat: add backend REST endpoint POST /settlements
Revert "feat: add backend REST endpoint POST /settlements"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
closes#120
#120 feat: add backend REST endpoint POST /settlements/:id/execute
Repo Avatar
WHEELBACK/COMEBACKHERE
Description
Implement the POST /settlements/:id/execute endpoint that triggers execution of a settlement once the approval threshold has been met. The endpoint calls execute_settlement on the contract and handles the PartiallyExecuted state where execution succeeded for some but not all transfers.
Requirements and context
Call execute_settlement on the settlement contract via Soroban RPC
Handle the case where the approval threshold has not yet been met with a 422 response
Handle PartiallyExecuted state: return partial success response with details of which transfers succeeded and which failed
Return final settlement status and transaction hash on full success
Follow existing project conventions
Suggested execution
Fork the repo and create a branch
git checkout -b feat/backend-post-settlement-execute
Implement changes
Test and commit
Example commit message
feat: add backend REST endpoint POST /settlements/:id/execute
Guidelines
Assignment required before starting
PR description must include: Closes #[issue_id]
Keep PR description professional and detailed