bugfix #4 - validate_records drops col if first row cell null with list#5
Open
sbatchelder wants to merge 1 commit into
Open
bugfix #4 - validate_records drops col if first row cell null with list#5sbatchelder wants to merge 1 commit into
sbatchelder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds two tests and fixes #4 .
Problem
When
validate_recordsreceiveslist[dict]input, it built the Arrow table withpa.Table.from_pylist(processed)— without passing the target schema. PyArrow then inferred the columns from the records themselves. If the first record omitted a nullable list column, the column was inferred as all-null and every later record's list value was silently dropped. The result was order-dependent: the same records in a different order produced different output.Fix
Build the table against the declared schema instead of letting PyArrow infer it:
Passing
schema=build_schemais the key change — column types now come from the schema, not from whichever record happens to be inferred first.build_schemais restricted to the schema fields actually present across the input rather than the full schema. This preserves the existing downstream behavior: missing required columns still raiseValueError, and missing nullable columns are still null-filled.Tests
Adds two regression tests covering