⚡ Bolt: Consolidate ownership and permission modifications into a single pass

.jules/bolt.md

@@ -4,3 +4,6 @@
 ## 2024-05-15 - Python Native Directory Traversal vs External Subprocesses
 **Learning:** Shelling out to external utilities like `find` via `os.system` or `subprocess` within Python scripts introduces significant overhead due to subshell spawning and external process execution. This is especially true when performing multiple independent `find` calls on the same directory tree.
 **Action:** Use native Python libraries like `os.walk` or `os.scandir` combined with `os.chmod`, `os.chown`, etc., to traverse directories in a single pass and eliminate subprocess overhead. This reduces execution time and improves cross-platform compatibility.
+## 2026-06-25 - Consolidating os.walk for Permissions and Ownership
+**Learning:** Performing multiple independent file tree operations (e.g. `os.system('chown -R')` followed by a native `os.walk` for `chmod`) causes redundant I/O and unnecessary subshell spawns.
+**Action:** Combine `os.chown` and `os.chmod` operations into a single native Python `os.walk` loop to perform all file metadata modifications in a single pass.

cidata_ingest.py

@@ -79,21 +79,35 @@ def decrypt_secrets_archive(enc_file):
         print(f"ERROR: Extraction failed! {res_extract.stderr}")
         return False
 
-    # Correct ownership and permissions of home directory files
-    print("Correcting ownership to user shane (1000:1000)...")
-    os.system("chown -R 1000:1000 /target/home/shane/")
-
-    # Enforce strict 600 permissions for ingested secrets
-    # ⚡ Bolt: Replaced external find/chmod subprocesses with native python os.walk.
-    # Impact: Avoids spawning multiple subshells and redundant directory traversals, significantly speeding up ingestion.
+    # Correct ownership and enforce strict 600 permissions for ingested secrets
+    # ⚡ Bolt: Replaced external os.system("chown") with native python os.chown inside os.walk.
+    # Impact: Combines ownership and permission modifications into a single pass, eliminating a subshell and redundant I/O.
+    print("Correcting ownership to user shane (1000:1000) and setting permissions...")
     target_dir = '/target/home/shane/'
+
+    try:
+        os.chown(target_dir, 1000, 1000)
+    except OSError as e:
+        print(f"Warning: could not set ownership for {target_dir}: {e}")
+
     for root, dirs, files in os.walk(target_dir):
+        for d in dirs:
+            dirpath = os.path.join(root, d)
+            try:
+                os.chown(dirpath, 1000, 1000)
+            except OSError as e:
+                print(f"Warning: could not set ownership for {dirpath}: {e}")
         for file in files:
+            filepath = os.path.join(root, file)
+            try:
+                os.chown(filepath, 1000, 1000)
+            except OSError as e:
+                print(f"Warning: could not set ownership for {filepath}: {e}")
             if file in ('rclone.conf', 'claude.json'):
                 try:
-                    os.chmod(os.path.join(root, file), 0o600)
+                    os.chmod(filepath, 0o600)
                 except OSError as e:
-                    print(f"Warning: could not set permissions for {file}: {e}")
+                    print(f"Warning: could not set permissions for {filepath}: {e}")
 
     print("Secrets decryption and ingestion completed successfully.")
     return True