Open
Conversation
davidwalter2
reviewed
Mar 4, 2026
Collaborator
davidwalter2
left a comment
davidwalter2
left a comment
There was a problem hiding this comment.
I'm not sure if it should be treated as theoryCorr or adding a new command line argument as it is done now, both works. Maybe @kdlong has an opinion.
| def parse_args(): | ||
| parser = parsing.base_parser() | ||
| parser.add_argument( | ||
| "massive_file", |
Collaborator
There was a problem hiding this comment.
Usually we use camelCase format for command line arguments because "-" and "" are being converted into "" I think. Could you change that in massiveFile and follow that also for other arguments?
| axis_absy = h2d.axes["absYVgen"] | ||
| axis_pt = h2d.axes["ptVgen"] | ||
| axis_Q = hist.axis.Regular(1, 60, 120, name="Q", underflow=True, overflow=True) | ||
| axis_charge = hist.axis.Regular(1, 0, 1, name="charge") |
Collaborator
There was a problem hiding this comment.
set underflow and overflow to false?
| passSystToFakes=passSystToFakes, | ||
| ) | ||
|
|
||
| rabbit_helpers.add_mb_fo_uncertainty( |
Collaborator
There was a problem hiding this comment.
Should make a check if the histogram is available to keep backwards compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds b-quark mass uncertainties in the Z dilepton workflow.