Sp provision api feature#357
Open
gayanch wants to merge 65 commits intoWSO2Telco:sp-provision-api-featurefrom
Open
Sp provision api feature#357gayanch wants to merge 65 commits intoWSO2Telco:sp-provision-api-featurefrom
gayanch wants to merge 65 commits intoWSO2Telco:sp-provision-api-featurefrom
Conversation
…t in same session
lahiru823
reviewed
Jul 10, 2018
| @@ -0,0 +1,121 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- Copyright (c) 2015-2016, WSO2.Telco Inc. (http://www.wso2telco.com) | |||
| .post(body) | ||
| .addHeader("authorization", "Basic " + encoding) | ||
| .addHeader("content-type", "application/x-www-form-urlencoded") | ||
| .addHeader("cache-control", "no-cache") |
Contributor
There was a problem hiding this comment.
remove
.addHeader("cache-control", "no-cache")
.addHeader("postman-token", "37e6d409-ba6d-b94d-50d2-273b7d671a84")
| loginToAm(userName); | ||
| } catch (IOException ex) { | ||
| logInstance.error("IO Exception occured when trying to login to the user in Add subscription " + | ||
| "process" + ex.toString(), ex); |
Contributor
There was a problem hiding this comment.
llogInstance.error("IO Exception occured when trying to login to the user in Add subscription " +
-
"process" + ex.getMessage(), ex);
|
|
||
| if (serviceProvider != null) { | ||
| InboundProvisioningConfig inboundProvisioningConfig = serviceProvider.getInboundProvisioningConfig(); | ||
| InboundAuthenticationRequestConfig[] x = serviceProvider.getInboundAuthenticationConfig() |
Contributor
There was a problem hiding this comment.
pls use meaningful name for x
| */ | ||
| private LocalAuthenticatorConfig[] setLocalAuthenticatorConfigObject() { | ||
| LocalAuthenticatorConfig localAuthenticatorConfig1 = new LocalAuthenticatorConfig(); | ||
| localAuthenticatorConfig1.setDisplayName("LOA"); |
| public static Connection getConnectionToAxiataDb() throws SQLException { | ||
| try { | ||
| Connection con = DbUtils.getDbConnection(DataSourceNames.WSO2TELCO_DEP_DB); | ||
| con.setAutoCommit(true); |
Contributor
There was a problem hiding this comment.
lets not explicitly set this. we can define this in the data source
…ovided by API request body
…ovided by API request body
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.