Brightness/contrast control + Print complete notification#30
Open
lhofinger wants to merge 4 commits intoWalkerFrederick:mainfrom
Open
Brightness/contrast control + Print complete notification#30lhofinger wants to merge 4 commits intoWalkerFrederick:mainfrom
lhofinger wants to merge 4 commits intoWalkerFrederick:mainfrom
Conversation
Owner
|
This looks awesome! I'll check it out in more detail this week. |
Author
|
Have you had a moment to take a look?
…On Tue, Mar 17, 2026 at 2:39 AM Walker Frederick ***@***.***> wrote:
*WalkerFrederick* left a comment (WalkerFrederick/CC-Tool#30)
<#30 (comment)>
This looks awesome! I'll check it out in more detail this week.
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJR6KARQ4RRRSR2MQZ4FX334RCUGLAVCNFSM6AAAAACWR2OBPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANZRG42TONJZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
hey Laurent, looks good! couple of questions...
if you split the brightness/contrast work into a separate PR I will happily merge, but notifications might need us to come up with a more complex implementation. I really, really appreciate your contribution! Thank you so much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on Android:
If you are interested...
Laurent