Skip to content

Add KB governance review controls#53

Merged
WalksWithASwagger merged 1 commit into
mainfrom
codex/issue-49-kb-governance
May 22, 2026
Merged

Add KB governance review controls#53
WalksWithASwagger merged 1 commit into
mainfrom
codex/issue-49-kb-governance

Conversation

@WalksWithASwagger
Copy link
Copy Markdown
Owner

Summary

  • Add knowledge_base/governance.yaml support for canonical voice anchors and ignored KB files.
  • Add reviewer actions to KB audit warnings and a pre-generation governance warning.
  • Add KB dialog controls plus docs/tests for private, stale, duplicate, and oversized context policy.

Verification

  • PYTHON=/Users/kk/Code/spektorAI/venv/bin/python make lint
  • PYTHON=/Users/kk/Code/spektorAI/venv/bin/python make test -> 285 passed
  • PYTHON=/Users/kk/Code/spektorAI/venv/bin/python make eval-fixture
  • git diff --check

Closes #49

@github-actions
Copy link
Copy Markdown

Agentic PR Review

Verdict: needs-human

Checks:

  • Linked issue via Closes #...: yes
  • Issue acceptance criteria found: 4
  • PR verification section present: yes
  • PR acceptance self-check present: no
  • PR self-check covers issue acceptance: no
  • Diff within v1 limits: yes
  • Missing acceptance coverage:
    • Profile KB audit separates stale, duplicate, private-looking, and oversized findings into clear reviewer actions.
    • A reviewer can mark canonical voice anchors and intentionally ignored files without editing code.
    • Generation surfaces a concise warning when selected profile context has unresolved governance findings.
    • Docs explain the private/stale policy and how future agents should treat flagged context.

This PR is not blocked from human review, but the agentic gate is not satisfied.

@github-actions github-actions Bot added the needs-human Agentic automation stopped for human judgment. label May 22, 2026
@WalksWithASwagger WalksWithASwagger merged commit 95459b7 into main May 22, 2026
1 check passed
@WalksWithASwagger WalksWithASwagger deleted the codex/issue-49-kb-governance branch May 22, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human Agentic automation stopped for human judgment.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add KB governance and profile-pack review workflow

1 participant